brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Wait for STOP effector to complet...
Date Thu, 29 Jan 2015 13:32:31 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/482#discussion_r23766971
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynTaskTags.java ---
    @@ -346,6 +347,26 @@ public static boolean isInEffectorTask(Task<?> task, @Nullable
Entity entity, @N
             return false;
         }
     
    +    @Beta
    +    public static Task<?> getEffectorParentTask(Task<?> child, Effector<?>
effector) {
    --- End diff --
    
    rename as `getClosestEffectorTask()` ?  it's not necessarily the parent.  `closest` is
used in the jquery sense.
    
    might be useful eventually to refactor to use predicates, but probably not yet...
    
    and add a one-line javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message