brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Jclouds tidy
Date Mon, 26 Jan 2015 12:18:00 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/465#discussion_r23526193
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocationConfig.java
---
    @@ -71,13 +72,25 @@
         public static final ConfigKey<String> LOGIN_USER_PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("loginUser.privateKeyFile",
                 "Custom private key for the user who logs in initially", null); 
         public static final ConfigKey<String> EXTRA_PUBLIC_KEY_DATA_TO_AUTH = ConfigKeys.newStringConfigKey("extraSshPublicKeyData",
    -            "Additional public key data to add to authorized_keys", null);
    +        "Additional public key data to add to authorized_keys", null);
    +    @SuppressWarnings("serial")
    +    public static final ConfigKey<List<String>> EXTRA_PUBLIC_KEYS_TO_AUTH
= ConfigKeys.newConfigKey(new TypeToken<List<String>>() {}, 
    --- End diff --
    
    agree, `EXTRA_PUBLIC_KEY_URLS_TO_AUTH` (here we can accept urls, falling back to file
format)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message