brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Jclouds tidy
Date Mon, 26 Jan 2015 11:34:47 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/
    @@ -71,13 +72,25 @@
         public static final ConfigKey<String> LOGIN_USER_PRIVATE_KEY_FILE = ConfigKeys.newStringConfigKey("loginUser.privateKeyFile",
                 "Custom private key for the user who logs in initially", null); 
         public static final ConfigKey<String> EXTRA_PUBLIC_KEY_DATA_TO_AUTH = ConfigKeys.newStringConfigKey("extraSshPublicKeyData",
    -            "Additional public key data to add to authorized_keys", null);
    +        "Additional public key data to add to authorized_keys", null);
    +    @SuppressWarnings("serial")
    +    public static final ConfigKey<List<String>> EXTRA_PUBLIC_KEYS_TO_AUTH
= ConfigKeys.newConfigKey(new TypeToken<List<String>>() {}, 
    --- End diff --
    For consistency with other names, should this be `EXTRA_PUBLIC_KEY_FILES_TO_AUTH`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message