brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Jclouds tidy
Date Mon, 26 Jan 2015 09:53:25 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/465#discussion_r23519856
  
    --- Diff: core/src/main/java/brooklyn/util/crypto/FluentKeySigner.java ---
    @@ -42,7 +44,9 @@
      * X509v3CertificateBuilder drags in an add'l dependency (bcmail) and is harder to use.
*/
     @SuppressWarnings("deprecation")
    --- End diff --
    
    I know it's not your code but couldn't help commenting...
    
    I'd prefer us not to use a blanket `@SuppressWarnings("deprecation")` on the class. It
means we don't get told what we're using that is actually deprecated, which we should fix
(unless we're deliberately doing it for backwards compatibility reasons with multiple versions
of a library?!).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message