brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix StreamGobblerTest under Windo...
Date Fri, 16 Jan 2015 11:32:59 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/454#discussion_r23075625
  
    --- Diff: utils/common/src/test/java/brooklyn/util/stream/StreamGobblerTest.java ---
    @@ -41,9 +43,9 @@ public void testGobbleStream() throws Exception {
             StreamGobbler gobbler = new StreamGobbler(stream, out, null);
             gobbler.start();
             try {
    -            gobbler.join(10*1000);
    +            gobbler.join(1000*1000);
    --- End diff --
    
    That's a very long wait? Can we make it more like 30 seconds, if that is what windows
takes?  Should we make this in the `Integration` group if it's going to take many seconds?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message