brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on stop, ...
Date Fri, 09 Jan 2015 16:16:19 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/389#discussion_r22724439
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
    @@ -111,7 +118,15 @@ public void init() {
         protected void preStart() {
             ServiceNotUpLogic.clearNotUpIndicator(this, SHUTDOWN.getName());
         }
    -    
    +
    +    @Override
    +    protected void preStopConfirmCustom() {
    +        super.preStopConfirmCustom();
    +        if (Boolean.TRUE.equals(getAttribute(BrooklynNode.WEB_CONSOLE_ACCESSIBLE))) {
    --- End diff --
    
    I think @grkvlt means:
    ```
    isSet(AttributeSensor<Boolean>(true)) --> true
    isSet(AttributeSensor<Boolean>(false)) --> false
    isSet(AttributeSensor<Boolean>(null)) --> false
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message