brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: MongoDB and Node fixes
Date Fri, 09 Jan 2015 12:50:53 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/411#discussion_r22714071
  
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppSshDriver.java
---
    @@ -152,6 +152,8 @@ public void launch() {
                 appCommandLine = appCommand + " " + appFile;
             }
     
    +        // Ensure global NPM modules are on Node's path.
    +        commands.add("export NODE_PATH=\"$NODE_PATH:$(npm root -g)\"");
    --- End diff --
    
    I think we could rework the Node entity to install packages locally. Something for the
future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message