brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] incubator-brooklyn pull request: MongoDB and Node fixes
Date Fri, 09 Jan 2015 12:32:07 GMT
Github user neykov commented on a diff in the pull request:
    --- Diff: software/webapp/src/main/java/brooklyn/entity/webapp/nodejs/
    @@ -152,6 +152,8 @@ public void launch() {
                 appCommandLine = appCommand + " " + appFile;
    +        // Ensure global NPM modules are on Node's path.
    +        commands.add("export NODE_PATH=\"$NODE_PATH:$(npm root -g)\"");
    --- End diff --
    Looks like it's bad practice to rely on global modules, but not much to do if it's needed
by real-world apps.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message