brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add configuration to skip start i...
Date Fri, 09 Jan 2015 09:52:43 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/364#discussion_r22707994
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/BrooklynConfigKeys.java ---
    @@ -55,8 +57,36 @@
                 "this should include something readable, and must include a hash of all data
which differentiates an installation " +
                 "(e.g. version, plugins, etc), but should be the same where install dirs
can be shared to allow for re-use");
     
    -    public static final ConfigKey<Boolean> ENTITY_STARTED = newBooleanConfigKey("entity.started",
"Skip the startup process entirely, for running services", Boolean.FALSE);
    -    public static final ConfigKey<Boolean> SKIP_INSTALLATION = newBooleanConfigKey("install.skip",
"Skip the driver install commands entirely, for pre-installed software", Boolean.FALSE);
    +    /**
    +     * Set this configuration value to true if the entity installation, customization
and launch process is to be skipped entirely.
    +     * <p>
    +     * This is usually because the process or service the entity represents is already
present and started, as part of the image
    +     * being used. The {@link Startable#SERVICE_UP} attribute will be set in the usual
manner.
    +     * <p>
    +     * If this key is set on a {@link Location} then all entities in that location will
be treated in this way. This is useful
    +     * when the location is configured with a particular image containing installed and
running services.
    +     *
    +     * @see #ENTITY_RUNNING
    +     */
    +    public static final ConfigKey<Boolean> ENTITY_STARTED = newBooleanConfigKey("entity.started",
"Skip the startup process entirely, for running services");
    --- End diff --
    
    I'm concerned about the names `ENTITY_STARTED` and `ENTITY_RUNNING`. Looking at just the
name, there is no way anyone would guess the difference. There is also an inconsistency in
naming compared the `SKIP_INSTALLATION`.
    
    Maybe a better name would be `SKIP_START`? (I don't like that someone might think it means
"skip launch" - but we use "start" to mean the whole install+customize+launch, so I think
it's ok).
    
    Could change `ENTITY_RUNNING` to `SKIP_START_IF_RUNNING`.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message