brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BindDnsServer really supports Ubu...
Date Thu, 08 Jan 2015 16:30:59 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/355#discussion_r22662171
  
    --- Diff: software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java
---
    @@ -304,6 +275,45 @@ protected void appendTemplate(String template, String destination,
SshMachineLoc
                     String.format("rm -f %s", temp)));
         }
     
    +    // Mostly used in templates
    +
    +    protected Predicate<? super Entity> getEntityFilter() {
    --- End diff --
    
    Maybe `public` instead, put in interface?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message