brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Finer-grained STOP effector param...
Date Wed, 07 Jan 2015 10:59:59 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/422#discussion_r22580823
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
    @@ -614,6 +631,23 @@ public void stop(ConfigBag parameters) {
             if (log.isDebugEnabled()) log.debug("Stopped software process entity "+entity());
         }
     
    +    @VisibleForTesting
    +    public static boolean canStop(StopMode stopMode, boolean isEntityStopped) {
    --- End diff --
    
    The method is used in a test from a different package, that's why the public visibility
is needed.
    
    I changed the code a bit - the method is now protected with the test code providing a
public wrapper, no need for the annotation. wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message