brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Finer-grained STOP effector param...
Date Mon, 05 Jan 2015 16:03:04 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/422#discussion_r22468677
  
    --- Diff: software/base/src/main/java/brooklyn/entity/basic/SoftwareProcess.java ---
    @@ -261,6 +261,20 @@ private ChildStartableMode(boolean isDisabled, boolean isBackground,
boolean isL
             public static final ConfigKey<Boolean> STOP_MACHINE = ConfigKeys.newBooleanConfigKey("stopMachine",
                     "Whether to stop the machine provisioned for this entity:  'true', or
'false' are supported, "
                             + "with the default being 'true'", true);
    +
    +        //IF_NOT_STOPPED includes STARTING, STOPPING, RUNNING
    +        public enum StopMode { ALWAYS, IF_NOT_STOPPED, NEVER };
    +
    +        @Beta /** @since 0.7.0 semantics of parameters to restart being explored */
    +        public static final ConfigKey<StopMode> STOP_PROCESS_MODE = ConfigKeys.newConfigKey(StopMode.class,
"stopProcessMode",
    +                "When to stop the process with regard to the entity state", StopMode.IF_NOT_STOPPED);
    +
    +        @Beta /** @since 0.7.0 semantics of parameters to restart being explored */
    +        public static final ConfigKey<StopMode> STOP_MACHINE_MODE = ConfigKeys.newConfigKey(StopMode.class,
"stopMachineMode",
    +                "When to stop the machine with regard to the entity state. " +
    +                "ALWAYS will try to stop the machine even if the entity is already stopped,"
+
    --- End diff --
    
    Add a space at the end of the line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message