Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of hzbarcea@gmail.com designates
 209.85.192.46 as permitted sender)
Message-ID: <548B02EE.1020907@gmail.com>
Date: Fri, 12 Dec 2014 09:59:58 -0500
From: Hadrian Zbarcea <hzbarcea@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: dev@brooklyn.incubator.apache.org
Subject: Re: [VOTE] Release Apache Brooklyn 0.7.0-M2-incubating [rc3]
References: 
 <CABQFKi1EZ=ekPCOrMCOqgSe8zJBq5skLSaVqDMUddYkdDQYwCQ@mail.gmail.com>
In-Reply-To: 
 <CABQFKi1EZ=ekPCOrMCOqgSe8zJBq5skLSaVqDMUddYkdDQYwCQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

+1 (binding) contingent on noting the issues below and following up with 
another rc soon-ish.

I am torn on this one. My decision to +1 is supported by the following:
* this is a release candidate
* it's a pre 1.0 version
* the test error is not new
* the build error is for tooling not actual functionality (although part 
of getting started).

Findings:
1. Keys verify ok. See the warning [1] below, I think it should be 
addressed for a future release. The key is available however on a public 
server [2].
2. Notice, license files, ok.
3. Build from source distro without running tests gives an error [3]
4. Build from source distro and running tests gives another error [4], I 
think it is known one.
5. Sources are in the "brooklyn" package, I think moving to 
"org.apache.brooklyn" would be a mandatory prerequisite for graduation. 
Easier to get it done earlier.
6. Does work with other tests/environments I use.

Cheers,
Hadrian

[1] see below
-----------------
gpg: Signature made Tue 09 Dec 2014 10:32:54 AM EST using RSA key ID 
1801208C
gpg: Good signature from "Richard Downer <richard@apache.org>"
gpg:                 aka "Richard Downer <richard@frontiertown.co.uk>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the 
owner.
Primary key fingerprint: 2CEF 1CDD E034 7C7A 6322  0653 144E 29F0 1801 208C
-----------------

[2] https://pgp.mit.edu/pks/lookup?op=vindex&search=0x144E29F01801208C

[3] see below
-----------------
[INFO] Brooklyn Quick-Start Project Archetype ............ FAILURE [0.722s]
[INFO] ...
[INFO] 
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] 
------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-archetype-plugin:2.2:integration-test 
(default-integration-test) on project brooklyn-archetype-quickstart:
[ERROR] Archetype IT 'integration-test-1' failed: 
org.apache.maven.archetype.exception.ArchetypeGenerationFailure: Error 
merging velocity templates: Unable to find resource 
'archetype-resources/pom.xml'

[4] see below
-----------------
Failed tests:
SensorResourceTest.testGet:170->doSensorTest:143->doSensorTestUntyped:161 expected 
["12345 frogs"] but found [12345 frogs]
SensorResourceTest.testGetRaw:196->doSensorTest:143->doSensorTestUntyped:160 
» ClientHandler

[INFO] Brooklyn REST Server .............................. FAILURE [38.223s]
-----------------


On 12/09/2014 10:54 AM, Richard Downer wrote:
> This is to call for a vote for the source release of Apache Brooklyn
> 0.7.0-M2-incubating.
>
> The source tarball, including signatures, digests, etc can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/brooklyn/apache-brooklyn-0.7.0-M2-incubating-rc3
>
> The Git commit ID is 3b2eac0df44a8565aa2b4feec546e0a5fb486485
> https://git-wip-us.apache.org/repos/asf?p=incubator-brooklyn.git;a=commit;h=3b2eac0df44a8565aa2b4feec546e0a5fb486485
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/richard.asc
>
> Checksums of apache-brooklyn-0.7.0-M2-incubating-rc0.tar.gz:
> MD5: 3df15ee0f5e4b3b42263a4ab559f75bb
> SHA1: 7b64f8ae3312e8b26833e8f24392fa4c405cabc5
> SHA256: ac60bdbb3e57b681394d1b014cf3a2308d244b8b5e7ec811ab6c0a6d6d1e349d
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/brooklyn/KEYS
>
> Changes since rc2:
> - Remove Shockwave Flash files
> - Remove .jar and .war files from source release (all used as test
> resources); update tests to gracefully handle the missing test
> resources
>
> Please vote on releasing this package as Apache Brooklyn 0.7.0-M2-incubating.
>
> The vote will be open for 72 hours.
> [ ] +1 Release this package as Apache Brooklyn 0.7.0-M2-incubating
> [ ] +0 no opinion
> [ ] -1 Do not release this package because ...
>
>
> Thanks,
> Richard Downer