Return-Path: 
 <dev-return-4811-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8A6719EE7
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon, 22 Dec 2014 14:53:21 +0000 (UTC)
Received: (qmail 65541 invoked by uid 500); 22 Dec 2014 14:53:21 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 65510 invoked by uid 500); 22 Dec 2014 14:53:21 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 65499 invoked by uid 99); 22 Dec 2014 14:53:20 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2014 14:53:20 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 22 Dec 2014 14:53:19 +0000
Received: (qmail 64100 invoked by uid 99); 22 Dec 2014 14:52:59 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Dec 2014 14:52:59 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 16910A32968; Mon, 22 Dec 2014 14:52:59 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-389-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-389-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on
 stop, ...
Content-Type: text/plain
Message-Id: <20141222145259.16910A32968@tyr.zones.apache.org>
Date: Mon, 22 Dec 2014 14:52:59 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/389#discussion_r22169230
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java ---
    @@ -611,9 +615,22 @@ public void stop(ConfigBag parameters) {
             entity().setAttribute(SoftwareProcess.SERVICE_UP, false);
             ServiceStateLogic.setExpectedState(entity(), Lifecycle.STOPPED);
     
    +        DynamicTasks.queue("post-stop", new Callable<String>() { public String call() {
    +            postStopCustom();
    +            return null;
    +        }});
    +
             if (log.isDebugEnabled()) log.debug("Stopped software process entity "+entity());
         }
     
    +    /** 
    +     * Override to check whether stop can be executed.
    +     * Throw if stop should be aborted.
    +     */
    +    protected void preStopConfirmCustom() {
    --- End diff --
    
    Agree this is not very flexible, do you have anything in mind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---