brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on stop, ...
Date Fri, 12 Dec 2014 14:25:25 GMT
GitHub user neykov opened a pull request:

    BrooklynNode - unmanage on stop, fix abort logic

    * Allow entities to be able to abort their stop effector. If pre-stop is aborted the machine
will still be released.
    * Unmanage BrooklynNode on stop
    WARNING: Turns out that postStop wasn't wired up, it was never called. Nevertheless some
entities (i.e. CouchDBNode, NginxController, JavaWebAppSoftwareProcess) override it which
might introduce unwanted behaviour. Shall I remove the override in existing entities?

You can merge this pull request into a Git repository by running:

    $ git pull fix/brooklyn-node

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
commit ca67b5e0cd3835a3319f49b874208eaa1683527d
Author: Svetoslav Neykov <>
Date:   2014-12-12T13:01:25Z

    Don't stop underlying machine if there are active services at the node.
    So far pre-stop was throwing if there are running services, but machine shutdown was forced

commit 6958d346411d919a60b6687d842a0b9afabd719a
Author: Svetoslav Neykov <>
Date:   2014-12-12T13:25:36Z

    Wire up postStop to be called, unmanage BrooklynNode on stop.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message