brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on stop, ...
Date Mon, 22 Dec 2014 14:52:59 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/389#discussion_r22169230
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
    @@ -611,9 +615,22 @@ public void stop(ConfigBag parameters) {
             entity().setAttribute(SoftwareProcess.SERVICE_UP, false);
             ServiceStateLogic.setExpectedState(entity(), Lifecycle.STOPPED);
     
    +        DynamicTasks.queue("post-stop", new Callable<String>() { public String
call() {
    +            postStopCustom();
    +            return null;
    +        }});
    +
             if (log.isDebugEnabled()) log.debug("Stopped software process entity "+entity());
         }
     
    +    /** 
    +     * Override to check whether stop can be executed.
    +     * Throw if stop should be aborted.
    +     */
    +    protected void preStopConfirmCustom() {
    --- End diff --
    
    Agree this is not very flexible, do you have anything in mind?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message