brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Parent display name in location m...
Date Sat, 20 Dec 2014 21:50:02 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/409#issuecomment-67751114
  
    Looks good.
    
    Could you add a reason here for why `parentDisplayName` is being added. I wonder if that
will actually cover your use case (e.g. if using a `SubnetTier` then we'll get an extra layer
of location object that represents the subnet, rather than the parent being the original `JcloudsLocation`
or whatever.
    
    Ping me when the stdout is removed (on skype/e-mail), and I'll merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message