brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From richardcloudsoft <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: a few minor doc tweaks
Date Wed, 17 Dec 2014 19:41:16 GMT
Github user richardcloudsoft commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/404#discussion_r21997884
  
    --- Diff: docs/README.md ---
    @@ -206,9 +206,13 @@ You can then preview the public site of [localhost:4000](http://localhost:4000)
         _build/serve-public-site.sh
     
     Next it is recommended to go to the SVN dir and 
    -review the changes using the usual `svn` commands -- `status`, `diff`, `add`, `rm`, etc:
    +review the changes using the usual `svn` commands -- `status`, `diff`, `add`, `rm`, etc.
    +Note in particular that deleted files need special attention (there is no analogue of
    +`git add -A`!). Perhaps use:
     
         cd ${BROOKLYN_SITE_DIR-../../incubator-brooklyn-site-public}
    +    svn add * --force
    +    svn rm $( svn status | sed -e '/^!/!d' -e 's/^!//' )
    --- End diff --
    
    Wow that sed command makes my head spin. Assuming that ! after a / / pair means invert
the condition, then that looks feasible to me, but I hope it has been tested!
    
    There is an argument that people should be looking *very* *carefully* at deletions as
it means that we're potentially breaking external links/bookmarks. While I'm not too bothered
about /v/latest, I'd suggest adding a warning here about deleting files from the main website
- not a complete ban necessarily, but "proceed with care".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message