brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on stop, ...
Date Sat, 13 Dec 2014 01:49:12 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/389#discussion_r21784671
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
    @@ -80,6 +81,12 @@
             RendererHints.register(WEB_CONSOLE_URI, RendererHints.namedActionWithUrl());
         }
     
    +    private class UnmanageThread extends Thread {
    --- End diff --
    
    Should this be `public` in a class like `Entities` for reuse?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message