brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BrooklynNode - unmanage on stop, ...
Date Sat, 13 Dec 2014 01:46:06 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/389#discussion_r21784613
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java
---
    @@ -119,12 +134,20 @@ protected void preStop() {
             // Shutdown only if accessible: any of stop_* could have already been called.
             // Don't check serviceUp=true because stop() will already have set serviceUp=false
&& expectedState=stopping
             if (Boolean.TRUE.equals(getAttribute(BrooklynNode.WEB_CONSOLE_ACCESSIBLE))) {
    -            Preconditions.checkState(getChildren().isEmpty(), "Can't stop instance with
running applications.");
                 DynamicTasks.queue(Effectors.invocation(this, SHUTDOWN, MutableMap.of(ShutdownEffector.REQUEST_TIMEOUT,
Duration.ONE_MINUTE)));
             } else {
                 log.info("Skipping children.isEmpty check and shutdown call, because web-console
not up for {}", this);
             }
         }
    +    
    +    @Override
    +    protected void postStop() {
    +        super.postStop();
    +        //Don't unmanage in entity's task context as it will self-cancel the task.
    --- End diff --
    
    Can we not execute a task in a global context, and set the entity to null somewhere?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message