brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Parameterize stop effector
Date Tue, 09 Dec 2014 14:47:14 GMT
Github user nakomis commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/375#discussion_r21532276
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
    @@ -521,9 +532,14 @@ protected void restartChildren(ConfigBag parameters) {
          * invokes {@link #preStopCustom()}, {@link #stopProcessesAtMachine()}, then finally
          * {@link #stopAnyProvisionedMachines()} and sets state {@link Lifecycle#STOPPED}
          */
    -    public void stop() {
    +    public void stop(ConfigBag parameters) {
             log.info("Stopping {} in {}", entity(), entity().getLocations());
     
    +        StopSoftwareParameters.StopMachineMode isStopMachine = parameters.get(StopSoftwareParameters.STOP_MACHINE_TYPED);
    +
    +        if (isStopMachine==null)
    +            isStopMachine=StopSoftwareParameters.StopMachineMode.TRUE;
    --- End diff --
    
    Ah, the perils of copy-and-paste...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message