Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: hzbarcea <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-359-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-359-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: [BROOKLYN-92] Configure
 brokerNam...
Content-Type: text/plain
Message-Id: <20141129030057.5E6A094D0CA@tyr.zones.apache.org>
Date: Sat, 29 Nov 2014 03:00:57 +0000 (UTC)

Github user hzbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21048252
  
    --- Diff: software/messaging/src/test/java/brooklyn/entity/messaging/activemq/ActiveMQIntegrationTest.java ---
    @@ -80,7 +80,7 @@ public void canStartupAndShutdown() throws Exception {
             activeMQ = app.createAndManageChild(EntitySpec.create(ActiveMQBroker.class));
     
             activeMQ.start(ImmutableList.of(testLocation));
    -        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 10*60*1000), activeMQ, Startable.SERVICE_UP, true);
    +        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 60*1000), activeMQ, Startable.SERVICE_UP, true);
    --- End diff --
    
    I am torn on this one. I understand your point, yet I've been bit many times by such long timeout. If something goes wrong it wastes a lot of your time. However this is unrelated to the enhancement this patch proposes. If we ever wanted to talk about the merits of timeouts it can be done at a later time. Change reverted per your suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---