Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: sjcorbett <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-359-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-359-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: [BROOKLYN-92] Configure
 brokerNam...
Content-Type: text/plain
Message-Id: <20141128152814.5145694BD4D@tyr.zones.apache.org>
Date: Fri, 28 Nov 2014 15:28:14 +0000 (UTC)

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036276
  
    --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQDestinationImpl.java ---
    @@ -52,4 +57,12 @@ public void onManagementStarting() {
         protected void disconnectSensors() {
             if (jmxFeed != null) jmxFeed.stop();
         }
    +    
    +    protected String getBrokerName() {
    +        if (brokerName == null) {
    +            EntityLocal parent = (EntityLocal)getParent();
    --- End diff --
    
    You don't need to cast to an `EntityLocal` to call `getAttribute()` on `parent`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---