Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-352-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-352-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Feeds etc
Content-Type: text/plain
Message-Id: <20141120152327.EA5D1925782@tyr.zones.apache.org>
Date: Thu, 20 Nov 2014 15:23:27 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/352#discussion_r20651865
  
    --- Diff: utils/common/src/main/java/brooklyn/util/net/Urls.java ---
    @@ -28,10 +28,13 @@
     
     import javax.annotation.Nullable;
     
    +import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;
    --- End diff --
    
    I'd prefer us to use guava utilities where available, unless there's a compelling reason to do otherwise - see http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/io/BaseEncoding.html#base64(), or `base64Url()` if that is more appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---