Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-307-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-307-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: support multiple instances
 of the...
Content-Type: text/plain
Message-Id: <20141111014951.BCD5E9A67F2@tyr.zones.apache.org>
Date: Tue, 11 Nov 2014 01:49:51 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/307#discussion_r20127703
  
    --- Diff: core/src/main/java/brooklyn/util/osgi/Osgis.java ---
    @@ -395,6 +564,25 @@ public static boolean isExtensionBundle(Bundle bundle) {
                     EXTENSION_PROTOCOL.equals(Urls.getProtocol(location));
         }
     
    +    /** Takes a string which might be of the form "symbolic-name" or "symbolic-name:version" (or something else entirely)
    +     * and returns an array of 1 or 2 string items being the symbolic name or symbolic name and version if possible
    +     * (or returning {@link Maybe#absent()} if not, with a suitable error message). */
    +    public static Maybe<String[]> parseOsgiIdentifier(String symbolicNameOptionalWithVersion) {
    +        if (Strings.isBlank(symbolicNameOptionalWithVersion))
    +            return Maybe.absent("OSGi identifier is blank");
    +        
    +        String[] parts = symbolicNameOptionalWithVersion.split(":");
    +        if (parts.length>2)
    +            return Maybe.absent("OSGi identifier has too many parts; max one ':' symbol");
    +        
    +        try {
    +            Version.parseVersion(parts[1]);
    +        } catch (IllegalArgumentException e) {
    +            return Maybe.absent("OSGi identifier has invalid version string");
    --- End diff --
    
    the caller includes plenty of context message; given how it is used i think it would be overkill here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---