Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: andreaturli <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-304-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-304-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: fix Live-sanity check for
 BlobSto...
Content-Type: text/plain
Message-Id: <20141106130104.A6EBC8B9378@tyr.zones.apache.org>
Date: Thu,  6 Nov 2014 13:01:04 +0000 (UTC)

Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/304#discussion_r19942482
  
    --- Diff: locations/jclouds/src/test/java/brooklyn/entity/rebind/persister/jclouds/BlobStoreExpiryTest.java ---
    @@ -151,7 +150,7 @@ protected void doTestRenewAuth(boolean applyFix) throws IOException {
                 try {
                     assertContainerFound();
                     Assert.fail("should fail as long as "+RetryOnRenew.class+" is not working");
    -            } catch (Exception e) {
    +            } catch (AssertionError e) {
    --- End diff --
    
    Sorry, you are right I completely misunderstood the logic here.
    
    Problem is that I'm not able to reproduce the error even putting the expiration time to 1 sec. More soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---