brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix BrooklynMementoPersisterToMul...
Date Wed, 26 Nov 2014 11:26:20 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/361

    Fix BrooklynMementoPersisterToMultiFileTest.tearDown

    - stop management context before deleting mementoDir, otherwise the management context
can be reading/writing to dir at same time as we are trying to delete its contents.
    
    See https://builds.apache.org/job/incubator-brooklyn-pull-requests/org.apache.brooklyn$brooklyn-core/407/consoleFull
    
    ```
    2014-11-25 23:37:18,300 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - @BeforeMethod
brooklyn.entity.rebind.persister.BrooklynMementoPersisterTestFixture.setUp() finished in 214
ms
    2014-11-25 23:37:18,300 INFO  TESTNG INVOKING: "Surefire test" - brooklyn.entity.rebind.persister.BrooklynMementoPersisterTestFixture.testLoadAndCheckpointRawMemento()
    2014-11-25 23:37:18,301 INFO  TESTNG SKIPPED: "Surefire test" - brooklyn.entity.rebind.persister.BrooklynMementoPersisterTestFixture.testLoadAndCheckpointRawMemento()
finished in 1 ms
    org.testng.SkipException: Persister brooklyn.entity.rebind.persister.BrooklynMementoPersisterToMultiFile@f2fee1
not a BrooklynMementoPersisterToObjectStore
    	at brooklyn.entity.rebind.persister.BrooklynMementoPersisterTestFixture.testLoadAndCheckpointRawMemento(BrooklynMementoPersisterTestFixture.java:163)
    2014-11-25 23:37:18,302 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterMethod
brooklyn.entity.rebind.persister.BrooklynMementoPersisterToMultiFileTest.tearDown()
    2014-11-25 23:37:18,318 INFO  TESTNG FAILED CONFIGURATION: "Surefire test" - @AfterMethod
brooklyn.entity.rebind.persister.BrooklynMementoPersisterToMultiFileTest.tearDown() finished
in 0 ms
    brooklyn.util.exceptions.PropagatedRuntimeException: java.io.IOException: Unable to delete
'/tmp/BrooklynMementoPersisterToMultiFileTest-OAJF': delete returned false
    	at brooklyn.util.exceptions.Exceptions.propagate(Exceptions.java:91)
    	at brooklyn.util.os.Os$DeletionResult.throwIfFailed(Os.java:278)
    	at brooklyn.util.os.Os$DeletionResult.asNullOrThrowing(Os.java:285)
    	at brooklyn.entity.rebind.persister.BrooklynMementoPersisterToMultiFileTest.tearDown(BrooklynMementoPersisterToMultiFileTest.java:57)
    Caused by: java.io.IOException: Unable to delete '/tmp/BrooklynMementoPersisterToMultiFileTest-OAJF':
delete returned false
    	... 33 more
    Caused by: java.io.FileNotFoundException: File does not exist: /tmp/BrooklynMementoPersisterToMultiFileTest-OAJF/enrichers/IE5jOu72.tmp
    	at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
    	at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
    	at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
    	at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2270)
    	at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
    	at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1535)
    	at brooklyn.util.os.Os.deleteRecursively(Os.java:239)
    	at brooklyn.util.os.Os.deleteRecursively(Os.java:225)
    	... 31 more
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/failing-BrooklynMementoPersisterToMultiFileTest-tearDown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #361
    
----
commit eff815d85dc07965ecda475172284098ce7255ba
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-26T11:25:03Z

    Fix BrooklynMementoPersisterToMultiFileTest.tearDown
    
    - stop management context before deleting mementoDir, otherwise
      the management context can be reading/writing to dir at same time
      as we are trying to delete its contents.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message