brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <>
Subject [GitHub] incubator-brooklyn pull request: Tomcat HTTPS
Date Wed, 12 Nov 2014 23:47:28 GMT
GitHub user sjcorbett opened a pull request:

    Tomcat HTTPS

    * Templates and copies `server.xml` and `web.xml` files to server rather than relying
on sed.
    * Extends `TomcatServer` to support HTTPS.
    * Hoists some useful bits from `Jboss7ServerImpl` to `JavaWebAppSoftwareProcessImpl`.
    I verified that the Tomcat integration tests all ran succesfully.
    ```mvn clean install -PIntegration -Dtest=TomcatServerWebAppFixtureIntegrationTest```
    The Jboss integration tests failed, but they fail for me on master too. Please run the
following command from `software/webapp` and do not merge this pull request if it does not
complete successfully. You should only need to test JBoss 7: disable the JBoss 6 test by commenting
out lines 40-42 and 49 of `JbossServerWebAppFixtureIntegrationTest`.
    ```mvn clean install -PIntegration -Dtest=JbossServerWebAppFixtureIntegrationTest#canStartAndStop```

You can merge this pull request into a Git repository by running:

    $ git pull tomcat-https

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #323
commit 46dfc41088d0b84f930b5fc98ceaf60a67d05a83
Author: Sam Corbett <>
Date:   2014-11-12T14:03:01Z

    Un-sed Tomcat configuration

commit ed00435c7434496bf5d1ec6e7b3f679712804bd6
Author: Sam Corbett <>
Date:   2014-11-12T23:26:09Z

    Tomcat entity supports HTTPS

commit 0dc8e38c4acb510046a3ae5674aab86d96065fb0
Author: Sam Corbett <>
Date:   2014-11-12T23:26:43Z

    Documentation improvements


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message