brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-92) Support for customized brokerName for ActiveMQ
Date Sat, 29 Nov 2014 03:01:12 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228609#comment-14228609
] 

ASF GitHub Bot commented on BROOKLYN-92:
----------------------------------------

Github user hzbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21048252
  
    --- Diff: software/messaging/src/test/java/brooklyn/entity/messaging/activemq/ActiveMQIntegrationTest.java
---
    @@ -80,7 +80,7 @@ public void canStartupAndShutdown() throws Exception {
             activeMQ = app.createAndManageChild(EntitySpec.create(ActiveMQBroker.class));
     
             activeMQ.start(ImmutableList.of(testLocation));
    -        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 10*60*1000),
activeMQ, Startable.SERVICE_UP, true);
    +        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 60*1000),
activeMQ, Startable.SERVICE_UP, true);
    --- End diff --
    
    I am torn on this one. I understand your point, yet I've been bit many times by such long
timeout. If something goes wrong it wastes a lot of your time. However this is unrelated to
the enhancement this patch proposes. If we ever wanted to talk about the merits of timeouts
it can be done at a later time. Change reverted per your suggestion.


> Support for customized brokerName for ActiveMQ
> ----------------------------------------------
>
>                 Key: BROOKLYN-92
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-92
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.7.0-M2
>
>
> Mandatory feature for more complex topologies, like networks of brokers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message