brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-92) Support for customized brokerName for ActiveMQ
Date Fri, 28 Nov 2014 15:31:12 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228330#comment-14228330
] 

ASF GitHub Bot commented on BROOKLYN-92:
----------------------------------------

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036362
  
    --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQDestinationImpl.java
---
    @@ -52,4 +57,12 @@ public void onManagementStarting() {
         protected void disconnectSensors() {
             if (jmxFeed != null) jmxFeed.stop();
         }
    +    
    +    protected String getBrokerName() {
    +        if (brokerName == null) {
    +            EntityLocal parent = (EntityLocal)getParent();
    +            brokerName = parent != null ? parent.getAttribute(ActiveMQBroker.BROKER_NAME)
: null;
    --- End diff --
    
    Will `parent` ever be null? I think it's an error if an `ActiveMQDestination` has no `ActiveMQBroker`
parent. So perhaps this whole method could be replaced with a simple `return getParent().getAttribute(ActiveMQBroker.BROKER_NAME)`.


> Support for customized brokerName for ActiveMQ
> ----------------------------------------------
>
>                 Key: BROOKLYN-92
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-92
>             Project: Brooklyn
>          Issue Type: Improvement
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.7.0-M2
>
>
> Mandatory feature for more complex topologies, like networks of brokers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message