brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-92] Configure brokerNam...
Date Fri, 28 Nov 2014 15:34:19 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036533
  
    --- Diff: software/messaging/src/test/java/brooklyn/entity/messaging/activemq/ActiveMQIntegrationTest.java
---
    @@ -80,7 +80,7 @@ public void canStartupAndShutdown() throws Exception {
             activeMQ = app.createAndManageChild(EntitySpec.create(ActiveMQBroker.class));
     
             activeMQ.start(ImmutableList.of(testLocation));
    -        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 10*60*1000),
activeMQ, Startable.SERVICE_UP, true);
    +        EntityTestUtils.assertAttributeEqualsEventually(ImmutableMap.of("timeout", 60*1000),
activeMQ, Startable.SERVICE_UP, true);
    --- End diff --
    
    I believe we have these really long time outs because integration tests often take much
much longer than you would expect when running on low powered CI machines (especially when
it has low bandwidth and has to download and install the program). Although they can be annoying
when running locally I think it's best we keep them in place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message