brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-92] Configure brokerNam...
Date Fri, 28 Nov 2014 15:26:27 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/359#discussion_r21036204
  
    --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/activemq/ActiveMQDestinationImpl.java
---
    @@ -39,9 +42,11 @@ public ActiveMQDestinationImpl() {
         public void onManagementStarting() {
             super.onManagementStarting();
             
    -        //assume just one BrokerName at this endpoint
    +        getBrokerName();
    +        Preconditions.checkNotNull(brokerName, "ActiveMQ broker name must be specified");
    --- End diff --
    
    I think it would be better to replace all references to `brokerName` with a call to `getBrokerName()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message