brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix various 20141120 (for PortFor...
Date Fri, 28 Nov 2014 11:41:46 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/353#discussion_r21027447
  
    --- Diff: core/src/main/java/brooklyn/location/access/PortForwardManager.java ---
    @@ -20,87 +20,71 @@
     
     import java.util.Collection;
     
    +import brooklyn.config.ConfigKey;
    +import brooklyn.entity.basic.ConfigKeys;
     import brooklyn.location.Location;
     
     import com.google.common.annotations.Beta;
     import com.google.common.net.HostAndPort;
     
     /**
    - * Records port mappings against public IP addresses with given identifiers.
    - * <p>
    - * To use, create a new authoritative instance (e.g. {@link PortForwardManagerAuthority})
which will live in one
    - * canonical place, then set config to be a client (e.g. {@link PortForwardManagerClient}
which delegates to the
    - * primary instance) so the authority is shared among all communicating parties but only
persisted in one place.
    - * <p>
    - * One Location side (e.g. a software process in a VM) can request ({@link #acquirePublicPort(String,
Location, int)})
    - * an unused port on a firewall / public IP address. It may then go on actually to talk
to that firewall/IP to
    - * provision the forwarding rule.
    - * <p>
    - * Subsequently the other side can use this class {@link #lookup(Location, int)} if it
knows the
    - * location and private port it wishes to talk to.
    - * <p>
    + * Acts as a registry for existing port mappings (e.g. the public endpoints for accessing
specific
    + * ports on private VMs). This could be using DNAT, or iptables port-forwarding, or Docker
port-mapping 
    + * via the host, or any other port mapping approach.
    + * 
    + * Also controls the allocation of ports via {@link #acquirePublicPort(String)}
    + * (e.g. for port-mapping with DNAT, then which port to use for the public side).
    + * 
    + * Implementations typically will not know anything about what the firewall/IP actually
is, they just 
    --- End diff --
    
    Duplicates sentence a few lines below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message