brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Mark tests in NetworkingUtilsTest...
Date Wed, 26 Nov 2014 12:23:01 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/360#discussion_r20931822
  
    --- Diff: utils/common/src/test/java/brooklyn/util/net/NetworkingUtilsTest.java ---
    @@ -107,8 +107,11 @@ public void testIsPortAvailableReportsTrueWhenPortIsFree() throws
Exception {
             if (numFree<=5)
                 fail("This test requires that at least some ports near 58769+ not be in use.");
         }
    -    
    -    @Test
    +
    +    // Integration because fails in apache jenkins sometimes with "could not get a port".
    +    // Could all the ports between 58767 and 60000 be in use (!) or is there a restriction
in
    --- End diff --
    
    Could be caused by parellel jenkins builds - i.e. master + PR builds. Isn't it better
to first try with a random port returned by new ServerSocket(0) before going for this step?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message