brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Feeds etc
Date Mon, 24 Nov 2014 14:00:59 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/352#discussion_r20790748
  
    --- Diff: core/src/main/java/brooklyn/entity/basic/AbstractEntity.java ---
    @@ -1246,20 +1258,31 @@ public void addEnricher(Enricher enricher) {
                 return null;
             }
         }
    -    private <T extends EntityAdjunct> T findApparentlyEqual(Collection<? extends
T> itemsCopy, T newItem) {
    -        // TODO workaround for issue where enrichers can get added multiple times on
rebind,
    -        // if it's added in onBecomingManager or connectSensors; the right fix will be
more disciplined about how/where these are added
    -        // (easier done when sensor feeds are persisted)
    +    private <T extends EntityAdjunct> T findApparentlyEqual(Collection<? extends
T> itemsCopy, T newItem, boolean transferUniqueTag) {
    --- End diff --
    
    `transferUniqueTag` is not used in the body


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message