brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Feeds etc
Date Thu, 20 Nov 2014 14:07:00 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/352#discussion_r20646470
  
    --- Diff: core/src/main/java/brooklyn/event/feed/http/HttpPollConfig.java ---
    @@ -159,9 +160,12 @@ public URI buildUri(URI baseUri, Map<String,String> baseUriVars)
{
             return MutableMap.<K,V>builder().putAll(map1).putAll(map2).build();
         }
     
    +    @Override protected String toStringBaseName() { return "http"; }
    +    @Override protected String toStringPollSource() { return suburl; }
         @Override
    -    public String toString() {
    -        return "http["+suburl+"]";
    +    protected MutableList<Object> equalsFields() {
    +        return super.equalsFields().appendIfNotNull(method).appendIfNotNull(vars).appendIfNotNull(headers)
    --- End diff --
    
    don't think we need positional parameters, and not sure we filter for `null` on the caller
side


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message