brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Feeds etc
Date Thu, 20 Nov 2014 13:00:54 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/352#discussion_r20643345
  
    --- Diff: core/src/main/java/brooklyn/event/feed/AbstractFeed.java ---
    @@ -79,7 +83,39 @@ public void setEntity(EntityLocal entity) {
                 ((EntityInternal)entity).feeds().addFeed(this);
             }
         }
    +
    +    protected void initUniqueTag(String uniqueTag, Object ...valsForDefault) {
    +        if (Strings.isNonBlank(uniqueTag)) this.uniqueTag = uniqueTag;
    +        else if (Strings.isBlank(this.uniqueTag)) this.uniqueTag = getDefaultUniqueTag(valsForDefault);
    --- End diff --
    
    no need for if isBlank


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message