brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Refactor rebind code, and tidy
Date Thu, 13 Nov 2014 22:50:03 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/309#discussion_r20330165
  
    --- Diff: core/src/test/java/brooklyn/entity/rebind/RebindOptions.java ---
    @@ -0,0 +1,92 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.entity.rebind;
    +
    +import java.io.File;
    +
    +import brooklyn.entity.rebind.persister.PersistenceObjectStore;
    +import brooklyn.management.ManagementContext;
    +
    +/**
    + * See {@link RebindTestFixture#rebind(RebindOptions)} and {@link RebindTestUtils#rebind(RebindOptions}}.
    + */
    +public class RebindOptions {
    +    boolean checkSerializable;
    +    boolean terminateOrigManagementContext;
    +    RebindExceptionHandler exceptionHandler;
    +    ManagementContext origManagementContext;
    +    ManagementContext newManagementContext;
    +    File mementoDir;
    +    File mementoDirBackup;
    +    ClassLoader classLoader;
    +    PersistenceObjectStore objectStore;
    --- End diff --
    
    `terminateOrigManagementContext` is currently defaulting to false (based on the overloaded
`rebind()` methods that existed before these changes. Arguably it should be `true`. We can
think about that more after this is merged, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message