brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Refactor config methods
Date Wed, 12 Nov 2014 16:10:00 GMT
GitHub user aledsage reopened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/320

    Refactor config methods

    Creates a BrooklynObject.config(), and deprecates the crazy number of inconsistent config
accessor/setter methods we have on Entity/Location/Policy/Enricher.
    
    Note that `AbstractEntity`, `AbstractLocation` and `AbstractEntityAdjuct` all still have
their own implementation of config. Until we delete the additional deprecated access/setter
methods, it will be difficult to rationalise this down into a single implementation within
`AbstractBrooklynObject`. I suggest we do that as soon as we begin work on 0.8.0-SNAPSHOT.
    
    Please merge https://github.com/apache/incubator-brooklyn/pull/319 first (for the groovy
version upgrade to 2.3.4). Without that, it fails to compile with `BrooklynObject.config()`
returning `ConfigurationSupport` and `BrooklynObjectInternal.config()` returning the sub-class
`ConfigurationSupportInternal`.
    
    When reviewing, please focus on the two commits `Add BrooklynObject.config()` and `Deprecate
*Config methods in Location/Enricher/Policy`. The other commits contain a massive number of
boring changes to make things use the new `config().set(key, val)` rather than the old `setConfig(key,
val)` etc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn refactor/config-methods-separation-strike2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #320
    
----
commit 00e8f1179dfcf77b331fce5aa874ce53c6afbedd
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-10T19:05:53Z

    Add BrooklynObject.config()
    
    - With separate implementations for Entity, Location and
      AbstractEntityAdjunct.
    - CatalogItemDo / CatalogItemDtoAbstract throw UnsupportedOperationException

commit 636edfcddf4913bd3afd536a14d8e5fbef686011
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-11T14:48:58Z

    Bump groovy version to 2.3.4 from 1.8.6
    
    - And groovy-eclipse-compiler to 2.9.0-01 from 2.7.0-01
    - And groovy-eclipse-batch to 2.3.4-01 from 1.8.6-01

commit 3ee3f8be7a66b1ec16d3d3a3054e942115f6cebf
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-11T15:25:09Z

    Use entity.config(), instead of newly deprecated methods
    
    - Have deprecated much of entity.*Config methods
      (all except entity.getConfig() as that is used so often).
    - Changed all uses to the new config().* variants.

commit 3bb649b04e8a7e4e69fff537ad78e88bfb4a8b97
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-11T16:50:17Z

    Deprecate *Config methods in Location/Enricher/Policy

commit e2c3d7325f6bd94d53e93644d6866676f37544ad
Author: Aled Sage <aled.sage@gmail.com>
Date:   2014-11-11T16:51:16Z

    Use {location,policy,enricher}.config(), instead of newly deprecated methods

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message