brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Couchbase changes for Clocker
Date Tue, 11 Nov 2014 22:48:12 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/317#discussion_r20187684
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/couchbase/CouchbaseNodeImpl.java
---
    @@ -59,17 +60,20 @@
     import brooklyn.util.text.Strings;
     import brooklyn.util.time.Duration;
     
    +import com.google.common.base.Charsets;
     import com.google.common.base.Function;
     import com.google.common.base.Functions;
     import com.google.common.base.Preconditions;
    +import com.google.common.net.HostAndPort;
    +import com.google.common.net.HttpHeaders;
     import com.google.common.net.MediaType;
     import com.google.gson.JsonArray;
     import com.google.gson.JsonElement;
     
     public class CouchbaseNodeImpl extends SoftwareProcessImpl implements CouchbaseNode {
    -    
    +
         private static final Logger log = LoggerFactory.getLogger(CouchbaseNodeImpl.class);
    -    
    +
         HttpFeed httpFeed;
    --- End diff --
    
    `private transient` for this, I think, is idiomatic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message