brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Versioning catalog items (take 2)
Date Tue, 11 Nov 2014 08:12:23 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/312#discussion_r20136740
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/CatalogXmlSerializer.java ---
    @@ -54,7 +59,7 @@ public CatalogXmlSerializer() {
             xstream.registerConverter(new EnumCaseForgivingSingleValueConverter(CatalogScanningModes.class));
     
             xstream.aliasType("libraries", CatalogLibrariesDto.class);
    -        xstream.addImplicitCollection(CatalogLibrariesDto.class, "bundles", "bundle",
String.class);
    +        xstream.addImplicitCollection(CatalogLibrariesDto.class, "bundles", "bundle",
CatalogBundleDto.class);
    --- End diff --
    
    It will be. I've put a note to myself to check if it can be done in a backwards compatible
without introducing additional properties. Not sure if it's worth doing anything though because
this concerns only catalog.xml deserialization which I haven't seen used with libraries so
far.
    
    I'll check if I can do anything about it and if not will ask for feedback on the mailing
list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message