brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Allow a UsageListener (i.e. for m...
Date Mon, 10 Nov 2014 11:42:03 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/310#discussion_r20077403
  
    --- Diff: software/base/src/test/java/brooklyn/management/usage/RecordingUsageListener.java
---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package brooklyn.management.usage;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +import brooklyn.management.internal.UsageManager.UsageListener;
    +import brooklyn.management.usage.ApplicationUsage.ApplicationEvent;
    +import brooklyn.management.usage.LocationUsage.LocationEvent;
    +import brooklyn.util.collections.MutableList;
    +
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Lists;
    +
    +public class RecordingUsageListener implements UsageListener {
    +
    +    private final List<List<?>> events = Lists.newCopyOnWriteArrayList();
    +    
    +    protected List<List<?>> getMutableEvents() {
    +        return events;
    +    }
    +    
    +    @Override
    +    public void onApplicationEvent(String applicationId, String applicationName, String
entityType, 
    +            Map<String, String> metadata, ApplicationEvent event) {
    +        getMutableEvents().add(MutableList.of("application", applicationId, applicationName,
entityType, metadata, event));
    --- End diff --
    
    It was for another test to sub-class it, so that the `getMutableEvents()` returns a `static`
events field. Thus we could test the instance that was created reflectively (whose class was
defined in `brooklyn.properties`).
    
    I've changed this for the static instance to just record a reference to the listener instances,
rather than relying on `getMutableEvents()`. The test-logic therefore doesn't leak into the
other class as much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message