brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix Live-sanity tests
Date Mon, 10 Nov 2014 09:18:51 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/308#discussion_r20072045
  
    --- Diff: core/src/test/java/brooklyn/entity/rebind/RebindTestFixture.java ---
    @@ -114,9 +127,36 @@ public void tearDown() throws Exception {
     
             if (origManagementContext != null) Entities.destroyAll(origManagementContext);
             if (mementoDir != null) FileBasedObjectStore.deleteCompletely(mementoDir);
    +        if (mementoDirBackup != null) FileBasedObjectStore.deleteCompletely(mementoDir);
             origManagementContext = null;
         }
     
    +    protected void dumpMementoDir(File dir) {
    --- End diff --
    
    Could use a brief javadoc comment, particularly describing what gets created at the target
dir.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message