brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Persistence better logging and op...
Date Thu, 06 Nov 2014 11:01:19 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/303#discussion_r19937753
  
    --- Diff: core/src/main/java/brooklyn/config/BrooklynLogging.java ---
    @@ -25,4 +30,45 @@
     
         public static final String REST = "brooklyn.REST";
     
    +    /** For convenience here, since SLF4J does not define such an enum */
    +    public static enum LoggingLevel { ERROR, WARN, INFO, DEBUG, TRACE }
    +
    +    /** As methods on {@link Logger} but taking the level as an argument */
    +    public static final void log(Logger logger, LoggingLevel level, String message, Object...
args) {
    +        switch (level) {
    --- End diff --
    
    Always a good idea to have a `default: ` as well, in case someone changes it later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message