brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Persistence better logging and op...
Date Thu, 06 Nov 2014 10:59:34 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/303#discussion_r19937661
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/CatalogUtils.java ---
    @@ -89,14 +92,18 @@ public static void installLibraries(ManagementContext managementContext,
@Nullab
                 if (osgi.isAbsent()) {
                     throw new IllegalStateException("Unable to load bundles "+bundles+" because
OSGi is not running.");
                 }
    -            if (log.isDebugEnabled()) log.debug("Loading bundles in {}: {}", 
    +            if (log.isDebugEnabled()) 
    +                logDebugOrTraceIfRebinding(log, 
    +                    "Loading bundles in {}: {}", 
    --- End diff --
    
    I much prefer 8 character indent for wrapped lines. In general, it makes stand out much
clearer that this is not just an indent for the next statement. Most of our other code uses
that convention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message