brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Persistence better logging and op...
Date Thu, 06 Nov 2014 10:34:59 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/303#discussion_r19936699
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java ---
    @@ -1235,7 +1249,20 @@ public void onUnmanaged(BrooklynObject instance) {
                 }
             }
         }
    +
    +    /** logs at debug, except during subsequent read-only rebinds, in which it logs trace
*/
    +    private void logRebindingDebug(String message, Object... args) {
    +        if (shouldLogRebinding()) {
    +            LOG.debug(message, args);
    +        } else {
    +            LOG.trace(message, args);
    +        }
    +    }
         
    +    protected boolean shouldLogRebinding() {
    +        return (readOnlyRebindCount < 5) || (readOnlyRebindCount%1000==0);
    --- End diff --
    
    it looks funny to check equals min_value and then check or < 5 !  leaving this as is,
unless you meant something else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message