brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix more integration tests
Date Tue, 04 Nov 2014 23:59:40 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/300#discussion_r19846569
  
    --- Diff: software/monitoring/src/test/java/brooklyn/entity/monitoring/monit/MonitIntegrationTest.java
---
    @@ -117,7 +119,21 @@ public void run() {
         }
         
         @Test(groups = "Integration")
    -    public void test_monitorMySqlAutoRestart() throws InterruptedException {
    +    public void test_monitorMySqlAutoRestart() throws Exception {
    +        // This runs on localhost; free to obtain another machine with impunity.
    +        final String osFlavor;
    +        MachineDetails machineDetails = app.getExecutionContext().submit(new Callable<MachineDetails>()
{
    +            public MachineDetails call() throws Exception {
    +                return loc.obtain().getMachineDetails();
    +            }}).get();
    +        if (machineDetails.getOsDetails().isMac()) {
    +            osFlavor = "osx10.6-x86_64";
    --- End diff --
    
    A little bit arbitrary? Or is 10.6 the only version _monit_ is available for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message