brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn node and cluster upgrade
Date Mon, 03 Nov 2014 15:49:41 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/272#issuecomment-61497766
  
    For your commit:
    
        change test logic to match EntityConfigMap behaviour for inheritance
        two implications of recent changes to EntityConfigMap caused failures in these tests,
        i think the new behaviour is desired:
        * any unknown flags/config set at parent remain is now NOT interpreted as flags at
children
        * getAllConfig() includes unknown config
    
    Not sure what this will break, by not interpreting string config keys as flags in children.
Guessing there will be some examples that rely on this.
    I expect the inconsistency for inherited config (i.e. flags work when it's top-level,
but not when it's inherited) will confuse some people.
    On balance, I'm ok with this change but not particularly happy with the behaviour either
way round.
    I wonder about the flags - is the convenience worth it for any confusion caused?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message