brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: fix dto.entries repetition errors...
Date Mon, 03 Nov 2014 15:00:56 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/289#discussion_r19737243
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/CatalogDto.java ---
    @@ -49,7 +52,8 @@
         String name;
         String description;
         CatalogClasspathDto classpath;
    -    List<CatalogItemDtoAbstract<?,?>> entries = null;
    +    private List<CatalogItemDtoAbstract<?,?>> entries = null;
    +//    Map<String,CatalogItemDtoAbstract<?,?>> entries = null;
    --- End diff --
    
    Commented out code deserves either being deleted, or a comment added to say why it would
be useful / what it means.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message