brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alasdairhodge <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix integration tests
Date Mon, 03 Nov 2014 13:41:35 GMT
Github user alasdairhodge commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/291#discussion_r19732714
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/mongodb/MongoDBServerImpl.java
---
    @@ -61,12 +61,17 @@ protected void connectSensors() {
             super.connectSensors();
             connectServiceUpIsRunning();
     
    -        int httpConsolePort = getAttribute(PORT) + 1000;
    -        if (httpConsolePort != getAttribute(HTTP_PORT)+1000) {
    +        int port = getAttribute(PORT);
    +        int httpConsolePort = getAttribute(HTTP_PORT);
    +        if (httpConsolePort !=  port + 1000) {
                 // see comment on HTTP_PORT
    -            LOG.warn(this+" may not have opened HTTP_PORT correctly as the default was
not available");
    +            LOG.warn("{} may not have opened HTTP_PORT correctly as the default was not
available: port={}; consolePort={}; resetting consolePort to {}", 
    +                    new Object[] {this, port, httpConsolePort, port + 1000});
    +            httpConsolePort = port + 1000;
    --- End diff --
    
    Mongo's behaviour is... weird. On our side, `HTTP_PORT` should be discoverable but non-settable,
i.e. a plain attribute but not a config key.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message